[Buildroot] [PATCH] opus: allow to select fixed-point implementation
Peter Korsgaard
jacmet at uclibc.org
Wed Feb 5 08:20:54 UTC 2014
>>>>> "Sven" == Sven Neumann <neumann at teufel.de> writes:
> The default of choosing the fixed-point implementation if
> the target hardware does not have floating-point unit is not
> always the best choice. Modern ARM hardware has floating
> point support but most likely the fixed-point implementation
> in Opus will still perform better. In particular if your CPU
> supports the NEON extension.
> This commit allows to select the fixed-point implementation
> manually and sets the default based on the availability of
> a floating-point unit.
> Signed-off-by: Sven Neumann <neumann at teufel.de>
> ---
> package/opus/Config.in | 11 +++++++++++
> package/opus/opus.mk | 2 +-
> 2 files changed, 12 insertions(+), 1 deletion(-)
> diff --git a/package/opus/Config.in b/package/opus/Config.in
> index 12bdfbb..1cd991a 100644
> --- a/package/opus/Config.in
> +++ b/package/opus/Config.in
> @@ -13,3 +13,14 @@ config BR2_PACKAGE_OPUS
> quality stereo music.
> http://opus-codec.org
> +
> +if BR2_PACKAGE_OPUS
> +
> +config BR2_PACKAGE_OPUS_FIXED_POINT
> + bool "opus fixed-point implementation"
this should probably be:
bool "use fixed-point" if !BR2_SOFT_FLOAT
E.G. only allow it to be disabled if you have hardware floating point.
Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list