[Buildroot] [PATCH] dependencies.sh: cleanup dependencies.sh

Thomas De Schampheleire patrickdepinguin at gmail.com
Wed Feb 5 11:47:16 UTC 2014


Hi,

On Tue, Feb 4, 2014 at 11:35 PM, Maxime Hadjinlian
<maxime.hadjinlian at gmail.com> wrote:
[..]
>>
>> Are you really suggesting we should remove all nesting? Well, I guess
>> there's been a problem with the e-mail or something...
> Well, I asked Peter before doing this, the file contained mixed indents. We
> thought it would be nice to have a consistent indent with the Mk files.
>
> But if we find we don't want that because it removes clarity in the code. I
> can perfectly resend with only the space/tab fixed.
>
> I really don't have a strong opinion on this one. Thomas Petazzoni and Yann
> E. Morin also found it disturbing.
> Peter what is your decision ?
>>

My preference would be to keep indenting nested levels, but
consistently with either tabs or spaces. As there are sometimes 4
nested levels, not indenting makes it hard to understand at first
sight.

Best regards,
Thomas



More information about the buildroot mailing list