[Buildroot] [pkg-perl infra V4 6/9] perl: remove useless patch

François Perrad francois.perrad at gadz.org
Wed Feb 5 19:46:46 UTC 2014


2014-02-05 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>:
> Dear Francois Perrad,
>
> On Wed,  5 Feb 2014 14:52:57 +0100, Francois Perrad wrote:
>>
>> Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
>> ---
>>  package/perl/perl-fix-Module-Build.patch |   16 ----------------
>>  1 file changed, 16 deletions(-)
>>  delete mode 100644 package/perl/perl-fix-Module-Build.patch
>
> It would be good to indicate in the commit log why the patch was
> useless.
>

The Perl infrastructure uses a host version of Module-Build
(see previous commit "host-perl-module-build: new package").
The target version is never used.

François

> Sorry to bother you so much about commit logs, but they are *really*
> important. I can't tell you the number of times I look at the git
> commit logs in the history of Buildroot to understand why such or such
> choice was made. So I really want to have good commit logs, and a
> commit log such as "remove useless patch" is not a good commit log, as
> it doesn't explain *why* the change was made.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot



More information about the buildroot mailing list