[Buildroot] [PATCH 3/4] samba: convert to choice package

Samuel Martin s.martin49 at gmail.com
Fri Feb 7 22:20:28 UTC 2014


Hi Gustavo,

On Fri, Feb 7, 2014 at 9:52 PM, Gustavo Zacarias
<gustavo at zacarias.com.ar> wrote:

[...]

> diff --git a/package/samba/Config.in b/package/samba/Config.in
> index 1469075..d11401f 100644
> --- a/package/samba/Config.in
> +++ b/package/samba/Config.in
> @@ -1,270 +1,32 @@
> +comment "samba needs a toolchain w/ threads"
> +       depends on BR2_USE_MMU
> +       depends on !BR2_TOOLCHAIN_HAS_THREADS
> +
>  config BR2_PACKAGE_SAMBA
>         bool "samba"
>         depends on BR2_TOOLCHAIN_HAS_THREADS
>         depends on BR2_USE_MMU # fork()
> -       select BR2_PACKAGE_POPT
>         help
> -         Provides print services to all manner of SMB/CIFS clients,
> -         including the numerous versions of Microsoft Windows
> -         operating systems.
> -
> -         http://www.samba.org/
> -
> -         NOTE: A complete Samba install takes over 50MB of space,
> -               so choose only the components you need.
> -
> -comment "samba needs a toolchain w/ threads"
> -       depends on BR2_USE_MMU
> -       depends on !BR2_TOOLCHAIN_HAS_THREADS
> +         Provides secure, stable and fast file and print services
> +         for all clients using the SMB/CIFS protocol, such as all versions
> +         of DOS and Windows, OS/2, Linux and many others.
>
>  if BR2_PACKAGE_SAMBA
>

[...]

> +choice
> +       prompt "Samba version"
> +       default BR2_PACKAGE_SAMBA3
>         help
> -         Tool for executing client side MS-RPC functions using RPC
> -         calls from a UNIX workstation.
> +         Select the desired samba version.
>

[...]

> +       config BR2_PACKAGE_SAMBA3
> +       bool "3.6.x"

Indentation is weird here, no?

> +       select BR2_PACKAGE_POPT
>         help
> -         Include support for gamin
> +         The well-tested legacy branch.
>
> -comment "support gamin - disabled (requires gamin)"
> -       depends on !BR2_PACKAGE_GAMIN
> -
> -endmenu
> +endchoice
>
>  endif


Regards,


-- 
Samuel



More information about the buildroot mailing list