[Buildroot] [PATCH v5 4/5] dependencies.sh: XBMC needs java on the host

Mike Zick minimod at morethan.org
Fri Feb 14 12:51:55 UTC 2014


On Fri, 14 Feb 2014 09:39:30 +0100
Thomas Petazzoni <thomas.petazzoni at free-electrons.com> wrote:

> Dear Maxime Hadjinlian,
> 
> On Thu, 13 Feb 2014 23:59:53 +0100, Maxime Hadjinlian wrote:
> 
> > +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then
> > +	for prog in java; do
> 
> Since you're checking for only one program, there's no point in having
> a loop here. Just do:
> 
> 	if ! which java > /dev/null ; then
>

Wasn't there a patch this development session that replaced
the use of "which" with a standards compliant command?

Mike
> 
> Thanks,
> 
> Thomas




More information about the buildroot mailing list