[Buildroot] [PATCH 04/10] toolchain/external: add choice to select 'AT_LEAST_XXX' header version

[Arnout Vandecappelle]

On 18/02/14 00:00, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2014-02-17 23:45 +0100, Arnout Vandecappelle spake thusly:
>> On 16/02/14 21:08, Thomas De Schampheleire wrote:
>>> "Yann E. MORIN" <yann.morin.1998 at free.fr> schreef:
>>>> From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>>>>
>>>> Select the appropriate BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXX options for the
>>>> external, custom toolchain backend.
>>>>
>>>> We try to be conservative here, and default to kernel headers 2.6.x.
>>>>
>>>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>>>> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
>>>> Cc: Arnout Vandecappelle <arnout at mind.be>
>>>> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
>>>> ---
>>>> toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++
>>>> toolchain/toolchain-external/Config.in         |  2 +
>>>> 2 files changed, 67 insertions(+)
>>>> create mode 100644 toolchain/toolchain-external/Config-headers.in
>>>>
>>>> diff --git a/toolchain/toolchain-external/Config-headers.in b/toolchain/toolchain-external/Config-headers.in
>>>> new file mode 100644
>>>> index 0000000..60ac384
>>>> --- /dev/null
>>>> +++ b/toolchain/toolchain-external/Config-headers.in
>>>> @@ -0,0 +1,65 @@
>>>> +choice
>>>> +	bool "External toolchain kernel headers"
>>>> +	depends on BR2_TOOLCHAIN_EXTERNAL_CUSTOM
>>>> +	default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD
>>>> +
>>>
>>> Shouldn't there be a help text explaining what this is used for, so as to remove confusion about the fact that the kernel header version was already chosen when the toolchain was built?
>>
>>  Note, however, that you can't add help text to a choice. So the only
>> option is to add the text to every choice option.
> 
> Wrong. Just try... ;-)

 Duh, I was so convinced of that... I think I've given that feedback in
other reviews as well...


 Regards,
 Arnout


> 
>>  Ah, the limitations of Kconfig...
> 
> You talking to me? You talking to me?  :-)
> 
> Regards,
> Yann E. MORIN.
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F