[Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract

Yann E. MORIN yann.morin.1998 at free.fr
Wed Feb 26 21:48:52 UTC 2014


Arnout, All,

On 2014-02-26 22:33 +0100, Arnout Vandecappelle spake thusly:
> On 26/02/14 19:40, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> > 
> > ti-gfx uses custom extract commands, which first and foremost removes
> > the source dir unconditionally.
> > 
> > Thee side-effect of this is that make will re-extract, re-patch and
> > probably re-build ti-gfx at each run.
> 
>  There actually was a reason for this - I think the extract fails if you
> re-run it. Have you tried
> 
> make ti-gfx-extract; make ti-gfx-extract

I shall try that right away... Nope, works!

I eventually understood what was going on. Basically, when you run:

    make ti-gfx-extract

under the hood, it's as you did:

    make ti-gfx-source
    make ti-gfx-extract

But -source creates a stamp file. Then -extract would remove the
directory, thus removing the stamp file.

10 When you run make again, the stamp file for the download is missing, so
make tries to download it again (invisible, since we already have the
archive), creates the stamp file, and extract again, which removes the
stamp file.
20 GOTO 10.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list