[Buildroot] [git commit] Revert "prevent recursion in %_defconfig rules"

Peter Korsgaard peter at korsgaard.com
Fri Jan 17 20:55:39 UTC 2014


commit: http://git.buildroot.net/buildroot/commit/?id=b4ce9a04f05fe6862caaf1f8cbe2cb6f66340bb6
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

This reverts commit 94dd02f5d0ce89549a82a99c56602e1c4a73bae7.

The change breaks defconfigs from BR2_EXTERNAL, both for in-tree and
out-of-tree builds.

Besides, the problem reported in 94dd02f could not be reproduced.

I can read French, and I suspect a relative path was used for either
BR2_EXTERNAL or O.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Cc: Jérémy Rosen <jeremy.rosen at openwide.fr>
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
 Makefile |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 9adc0ec..9dfb1e0 100644
--- a/Makefile
+++ b/Makefile
@@ -762,14 +762,10 @@ defconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
 	@mkdir -p $(BUILD_DIR)/buildroot-config
 	@$(COMMON_CONFIG_ENV) $< --defconfig=$(TOPDIR)/configs/$@ $(CONFIG_CONFIG_IN)
 
-$(TOPDIR)/configs/%_defconfig:;
-
 %_defconfig: $(BUILD_DIR)/buildroot-config/conf $(BR2_EXTERNAL)/configs/%_defconfig outputmakefile
 	@mkdir -p $(BUILD_DIR)/buildroot-config
 	@$(COMMON_CONFIG_ENV) $< --defconfig=$(BR2_EXTERNAL)/configs/$@ $(CONFIG_CONFIG_IN)
 
-$(BR2_EXTERNAL)/configs/%_defconfig:;
-
 savedefconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
 	@mkdir -p $(BUILD_DIR)/buildroot-config
 	@$(COMMON_CONFIG_ENV) $< \


More information about the buildroot mailing list