[Buildroot] [PATCH v3 2/2] add support for building the server

Yann E. MORIN yann.morin.1998 at free.fr
Mon Jan 20 21:44:28 UTC 2014


Marcelo, All,

On 2014-01-19 23:02 +0000, Marcelo Gutiérrez spake thusly:
> From: "Marcelo Gutiérrez(UTN/FRH)" <kuyurix at gmail.com>

This one looks actually good to me! :-)

One minor nit, though:

This changelog:
> Changes v2 -> v3:
>         - rename field <number> in the patch file name
>         - update new options postion
>         - update description to Makefile
>         - update Config.in
> 
> Changes v1 -> v2:
>         - fix comments following new policy
>         - rename patches
>         - remove useless hook points
>         - add the URL to the home of MySQL
>         - add commit-log description to the patches
>         - install host tools to $(HOST_DIR)/usr/bin
>         - fix only builds the required program

should go...

> Signed-off-by: Marcelo Gutiérrez(UTN/FRH) <kuyurix at gmail.com>
> ---

Here, after the three-dash-line. git interprets this three-dash-line as
a marker for the end of the commit log, so it will not appear in the
history, since we don;t really need it.

(Ditto for your patch 1/2, too.)

Otherwise, looks good to me! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list