[Buildroot] [PATCH 1/2] Remove some absolute paths

Bjørn Forsman bjorn.forsman at gmail.com
Tue Jan 21 18:14:08 UTC 2014


On 21 January 2014 09:43, Peter Korsgaard <jacmet at uclibc.org> wrote:
>>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin at gmail.com> writes:
>
> Hi,
>
>  > Acked-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
>
>  > Although the discussion raised some interesting points, I believe this
>  > patch is ok to accept as-is.
>
> True. The explicit /bin/echo was afaik to make sure we end up with an
> echo variant (most likely coreutils) that understands -e, but if we're
> changing it to printf anyway.
>
> Committed, thanks.

Oops, this patch wasn't supposted to be commited all by itself and not
followed by the "[PATCH 2/2] Prefer
'printf' over 'echo -e' (for portability)" patch. With the current use
of "echo -e" there will be breakage if /bin/sh is dash.

Peter, could you apply the 2nd patch also and then I can submit a
separate patch afterwards to stop the echo/printf mix?

Best regards,
Bjørn Forsman



More information about the buildroot mailing list