[Buildroot] [PATCH] uboot-tools: Allow users to use uboot's sources

Thomas De Schampheleire patrickdepinguin at gmail.com
Tue Jan 28 06:02:56 UTC 2014


Hi Arnout,

Op 27-jan.-2014 22:28 schreef "Arnout Vandecappelle" <arnout at mind.be>:
>
> On 26/01/14 22:43, Luca Ceresoli wrote:
>>
>> Going a step ahead, to be more uniform with these packages, you may use
>> a choice construct to allow choosing between two alternatives.
>> Example (modified version of the code in barebox.mk):
>>
>> choice
>>          prompt "version"
>>          help
>>            Select the specific uboot-tools version you want to use
>>
>> config BR2_PACKAGE_UBOOT_TOOLS_LATEST_VERSION
>>          bool "Use a recent upstream version"
>>
>> config BR2_PACKAGE_UBOOT_TOOLS_USE_UBOOT_VERSION
>>          bool "Use the same sources of the uboot package"
>>
>> endchoice
>
>
>  Actually, I don't even see the need to ask the user anything. If we are
building U-Boot, I don't see why we would ever want to use the U-Boot tools
from upstream - that just adds a risk of incompatibility between the two.
>
>  So I would propose to remove the BR2_PACKAGE_UBOOT_TOOLS_UBOOT_SOURCE
option, and instead make it conditional on BR2_TARGET_UBOOT.

I don't agree here. Real life example: we are using vendor-provided uboot,
and want to set an env-image in our flash devices' factory image. While
this version of uboot clearly supports handling the env at a specified
location, it does not (yet) provide the mkenvimage tool.
In this case, we actually want a more recent uboot tools package that does
have mkenvimage. My conclusion is thus that we should provide the choice.

Best regards,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140128/335d2afb/attachment-0002.html>


More information about the buildroot mailing list