[Buildroot] [PATCH 2/2] linux: only depend on host-lzop if needed

Peter Korsgaard jacmet at uclibc.org
Tue Jan 28 22:17:32 UTC 2014


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > Dear Yann E. MORIN,
 > On Sun, 26 Jan 2014 14:56:27 +0100, Yann E. MORIN wrote:

 >> +ifeq ($(call KCONFIG_GET_OPT,CONFIG_KERNEL_LZO,$(call qstrip,$(KERNEL_SOURCE_CONFIG))),y)
 >> +LINUX_DEPENDENCIES += host-lzop
 >> +endif

 > Do this works reliably? KERNEL_SOURCE_CONFIG typically points to a
 > minimal defconfig file (say arch/arm/configs/mvebu_defconfig). So if
 > CONFIG_KERNEL_LZO is the default choice for the kernel, it will not
 > appear in the defconfig, and therefore the piece of code above will not
 > realize that we need host-lzop, because the test is done before "make
 > mvebu_defconfig" is executed and turns it back into a full
 > configuration file.

The commit message contained:

Since LZO is not the default compression option in the kernel (and there
is not sign that will change in the foreseeable future), it will always
appear in a condif file, whether it is a complete config file or it is
only a defconfig.

So I believe the answer is yes, it will work.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list