[Buildroot] [PATCH 2/2] linux: only depend on host-lzop if needed
Yann E. MORIN
yann.morin.1998 at free.fr
Tue Jan 28 22:21:23 UTC 2014
Thomas, All,
On 2014-01-28 23:14 +0100, Thomas Petazzoni spake thusly:
> On Sun, 26 Jan 2014 14:56:27 +0100, Yann E. MORIN wrote:
>
> > +ifeq ($(call KCONFIG_GET_OPT,CONFIG_KERNEL_LZO,$(call qstrip,$(KERNEL_SOURCE_CONFIG))),y)
> > +LINUX_DEPENDENCIES += host-lzop
> > +endif
>
> Do this works reliably? KERNEL_SOURCE_CONFIG typically points to a
> minimal defconfig file (say arch/arm/configs/mvebu_defconfig). So if
> CONFIG_KERNEL_LZO is the default choice for the kernel, it will not
> appear in the defconfig, and therefore the piece of code above will not
> realize that we need host-lzop, because the test is done before "make
> mvebu_defconfig" is executed and turns it back into a full
> configuration file.
I believe I've addresed your comments in the commit log itself:
---8<---
Since LZO is not the default compression option in the kernel (and there
is not sign that will change in the foreseeable future), it will always
appear in a condif file, whether it is a complete config file or it is
only a defconfig.
---8<---
Of course, re-reading myself now, I can now spot a typo:
s/condif/config/
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list