[Buildroot] [PATCH 1/3] Add $$(PKG)_AUTORECONF_ENV argument to autotools package autoreconf command to allow environment variables to be used.
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Jul 18 08:51:54 UTC 2014
Dear Rick Taylor,
On Fri, 18 Jul 2014 09:42:41 +0100, Rick Taylor wrote:
> Signed-off-by: Rick Taylor <rick.taylor at cassidian.com>
> ---
> package/pkg-autotools.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks. However, the commit log is not properly formatted. With git,
the commit log should have one line of less than ~80 characters that
summarizes the commit, then one empty new line, and then more details.
Also, in Buildroot, we like when the commit title has a prefix that
identifies the area of the change. I.e, in your case, something like:
===
pkg-autotools: add support for <pkg>_AUTORECONF_ENV
This commit improves the autotools-package infrastructure to support a
<pkg>_AUTORECONF_ENV variable, which allows to pass addition variables
in the environment of the autoreconf execution. This is useful in the
situation where blabla blibli ...
Signed-off-by: ...
===
Could you update your commit log with this format?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list