[Buildroot] [PATCH] gst-fsl-plugins: fix build for kernel headers >= 3.10

Gary Bisson bisson.gary at gmail.com
Sat Jul 26 17:12:33 UTC 2014


Yann, Thomas, all,

On Sat, Jul 26, 2014 at 3:01 AM, Yann E. MORIN <yann.morin.1998 at free.fr>
wrote:

> Thomas, All,
>
> On 2014-07-26 09:02 +0200, Thomas Petazzoni spake thusly:
> > On Fri, 25 Jul 2014 22:34:30 -0700, Gary Bisson wrote:
> > > This package couldn't build using a toolchain with kernel headers >=
> > > 3.10 because of the use of VIDIOC_DBG_G_CHIP_IDENT. As stated in
> > > videodev2.h, this ioctl should never be used.
> > >
> > > Signed-off-by: Gary Bisson <bisson.gary at gmail.com>
> > > ---
> > > Yann, Thomas, all,
> > > After looking at the source code it appears that nothing justifies the
> use of
> > > that obsolete ioctl. Its only purpose is to get the video device name
> so this
> > > patch actually removes those unnecessary calls.
> > > Thanks,
> > > Gary
> >
> > So, if I'm correct, this supersedes the patches from Yann
> > (http://patchwork.ozlabs.org/patch/373813/ and
> > http://patchwork.ozlabs.org/patch/373814/), right ?
>
> Well, 373813 is still valid: it is a clarification in the manual that
> _AT_LEAST_X_Y symbols can be used to require either lowest or highest
> headers version.
>
> So, even if we end up noy needing this for this issue, it is still
> valid, no?
>
> But indeed, 373814 is supersedded by this patch from Gary (and I'm happy
> of the outcome!) I'll mark the affected patches supserdded in Patchwork.
>

Agreed.
Regarding upstream gst-fsl-plugins, the patch will be sent to them this
week-end.

Thanks,
Gary
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140726/c8031351/attachment-0002.html>


More information about the buildroot mailing list