[Buildroot] [PATCH] add sob line for patch series

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Jul 29 16:45:32 UTC 2014


Dear Waldemar Brodkorb,

On Tue, 29 Jul 2014 17:01:30 +0200, Waldemar Brodkorb wrote:
> I think -s is missing here to automatically add
> the sob line, when using this example.
> 
> Signed-off-by: Waldemar Brodkorb <wbx at openadk.org>
> ---
>  docs/manual/contribute.txt |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt
> index 12e7f98..b7e8944 100644
> --- a/docs/manual/contribute.txt
> +++ b/docs/manual/contribute.txt
> @@ -272,7 +272,7 @@ This can be easily handled with +git format-patch+ by using the option
>  
>  ---------------------
>  $ git format-patch --subject-prefix "PATCH v4" \
> -    -M -o outgoing origin/master
> +    -M -s -o outgoing origin/master
>  ---------------------

I think the best practice should rather be to SoB when committing (i.e
'git commit -s') rather than when formatting patches, no?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list