[Buildroot] [PATCH v4 02/11] pkg-cmake.mk: do not hardcode absolute path in toolchainfile.cmake

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jun 1 10:57:09 UTC 2014


Dear Samuel Martin,

On Sun,  1 Jun 2014 11:24:24 +0200, Samuel Martin wrote:
> The patch allows sharing or moving the toolchains.
> 
> This is a step toward making the toolchain/sdk relocatable.
> 
> Closes #6818
> 
> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
> Cc: Uwe Strempel <u.strempel at googlemail.com>
> Cc: Arnout Vandecappelle <arnout at mind.be>

Reviewed-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

> +# In all the other variables that need to refer to HOST_DIR will use
> +# the RELOCATED_HOST_DIR variable.

There's a typo in this sentence. Either:

"""
All the other variables that need to refer to HOST_DIR will use the
RELOCATED_HOST_DIR variable.
"""

or

"""
In all the other variables that need to refer to HOST_DIR, we'll use
the RELOCATED_HOST_DIR variable.
"""

But hopefully Peter can fix this while applying.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list