[Buildroot] [PATCH v4 04/11] rpi-userland: cleanup *_CONF_OPT

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jun 1 11:04:19 UTC 2014


Dear Samuel Martin,

On Sun,  1 Jun 2014 11:24:26 +0200, Samuel Martin wrote:
> rpi-userland does not need -DBUILD_SHARED_LIBS=OFF to be passed to
> correclty build its static libraries; so remove this cmake flag from the
> configure options.
> 
> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
> Cc: "Yann E. MORIN" <yann.morin.1998 at free.fr>

As discussed in real-life, this should probably be squashed with PATCH
05/11, and with an expanded explanation that details why reverting
5e3b1f31b3f82e3b163567f10d7131c9d649a2cf does not re-introduce the bug
that 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf was fixing.

Maybe you should submit these fixes separately, since they are not
related to the CMake package infrastructure per se?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list