[Buildroot] [PATCH] packages: replace command install by $(INSTALL)

[Yann E. MORIN]

Jérôme, All,

On 2014-06-04 16:00 +0200, "Jérôme Pouiller" spake thusly:
> On Sunday 01 June 2014 14:38:01 Maxime Hadjinlian wrote:
> > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
> [...]
> > diff --git a/package/alsa-utils/alsa-utils.mk
> > b/package/alsa-utils/alsa-utils.mk index 48b4bfd..2083c97 100644
> > --- a/package/alsa-utils/alsa-utils.mk
> > +++ b/package/alsa-utils/alsa-utils.mk
> > @@ -41,7 +41,7 @@ LSA_UTILS_TARGETS_$(BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST)
> > += usr/bin/speaker-tes define ALSA_UTILS_INSTALL_TARGET_CMDS
> >       mkdir -p $(TARGET_DIR)/var/lib/alsa
> >       for i in $(ALSA_UTILS_TARGETS_y); do \
> > -             install -D -m 755 $(STAGING_DIR)/$$i $(TARGET_DIR)/$$i; \
> > +             $(INSTALL) -D -m 755 $(STAGING_DIR)/$$i $(TARGET_DIR)/$$i; \
> >       done
> >       if [ -x "$(TARGET_DIR)/usr/bin/speaker-test" ]; then \
> >               mkdir -p $(TARGET_DIR)/usr/share/alsa/speaker-test; \
> [...]
> 
> Just out of curiosity, why '$(INSTALL)' is preferred over 'install'?

Because it's been there for the past 9+ years? The commit #9cc9476c (more
dhcp updates) introduced this variable in 2005-02-16.

And because that's what we document in the manual? ;-)

More seriously, there's no much reason for now. But in the grand scheme
of the Universe, not all 'install' commands were made equal, so this
would allow us (in the case it is needed) to point $(INSTALL) to a
select 'install' command that we control.

Again, it's mostly historical bagage, but we want consistency acros
packages.

> And what about '$(RM)' versus 'rm'?

We do not have $(RM) currently, since all 'rm' commands are pretty much
on par with each others, so it is not really needed.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'