[Buildroot] [PATCH 1 of 7 v3] infra: consistently use double dollar signs inside inner-xxx-targets

Thomas De Schampheleire patrickdepinguin at gmail.com
Sun Jun 8 14:09:00 UTC 2014


Hi Yann,

On Fri, Jun 6, 2014 at 11:21 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> On 2014-06-06 22:12 +0200, Thomas De Schampheleire spake thusly:
>> This patch introduces consistent usage of double-dollar signs throughout the
>> different inner-xxx-targets blocks.
> [--SNIP--]
>> Insight-provided-by: Arnout Vandecappelle <arnout at mind.be>
>> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Tested-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

Thanks!

>
> I tested to build the manual: looks very similar to the original one, I
> did not spot any discrepancy.

I should have mentioned this in the commit message: I compared the
output of the manual (txt+html) and the legal info output (of one
particular config) before and after with success.

>
> I tested my lots-of-packages config to build XBMC on the RPi: the
> graph-depends is the exact same (same sha1, even!).
>
> I grepped the source to see if there was any remaining single-dollar
> signs that should have been covnerted, and for double-dollar signs: I
> could not spot any missing or abusive conversion.

Thanks for these tests and review!
Thomas



More information about the buildroot mailing list