[Buildroot] [PATCHv2 2/6] gettext: remove support for gettext-tools on target

[Yann E. MORIN]

Thomas, All,

On 2014-06-01 22:23 +0200, Thomas Petazzoni spake thusly:
> This commit removes the BR2_PACKAGE_GETTEXT_TOOLS option, which could
> be used to install gettext tools on the target. This is not needed,
> because Buildroot is not designed to provide a full development
> environment on the target, and gettext translation files should be
> processed on the build machine, using the host gettext tools.
> 
> Remove this option will allow to optimize the build time of gettext on
> the target, by only building the gettext runtime libraries.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Tested-by: Andrew Ruder <andrew.ruder at elecsyscorp.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

Regards,
Yann E. MORIN.

> ---
>  Config.in.legacy           | 12 ++++++++++++
>  package/gettext/Config.in  | 14 --------------
>  package/gettext/gettext.mk |  4 ----
>  3 files changed, 12 insertions(+), 18 deletions(-)
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 00661db..50f7363 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -99,6 +99,18 @@ comment "----------------------------------------------------"
>  endif
>  
>  ###############################################################################
> +comment "Legacy options removed in 2014.08"
> +
> +config BR2_PACKAGE_GETTEXT_TOOLS
> +	bool "support for gettext-tools on target has been removed"
> +	select BR2_LEGACY
> +	help
> +	  The option to install the gettext utilities on the target
> +	  has been removed. This is not necessary as Buildroot is not
> +	  designed to provide a full development environment on the
> +	  target. gettext tools should be used on the build machine
> +	  instead.
> +
>  comment "Legacy options removed in 2014.05"
>  
>  config BR2_PACKAGE_EVTEST_CAPTURE
> diff --git a/package/gettext/Config.in b/package/gettext/Config.in
> index d33dd3a..158b14e 100644
> --- a/package/gettext/Config.in
> +++ b/package/gettext/Config.in
> @@ -13,20 +13,6 @@ config BR2_PACKAGE_GETTEXT
>  
>  	  http://www.gnu.org/software/gettext/
>  
> -if BR2_PACKAGE_GETTEXT
> -
> -config BR2_PACKAGE_GETTEXT_TOOLS
> -	bool "Install gettext tools"
> -	depends on BR2_USE_MMU # fork()
> -	depends on BR2_LARGEFILE
> -	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
> -	help
> -	  This option allows to install the complete gettext suite in
> -	  the target filesystem. This is typically not useful for
> -	  correct operation of programs.
> -
> -endif
> -
>  comment "gettext needs a toolchain w/ wchar"
>  	depends on BR2_NEEDS_GETTEXT
>  	depends on !BR2_USE_WCHAR
> diff --git a/package/gettext/gettext.mk b/package/gettext/gettext.mk
> index b5efa76..52a72db 100644
> --- a/package/gettext/gettext.mk
> +++ b/package/gettext/gettext.mk
> @@ -46,16 +46,12 @@ ifeq ($(BR2_ENABLE_LOCALE),)
>  GETTEXT_CONF_OPT += --enable-nls
>  endif
>  
> -# When the gettext tools are not enabled in the configuration, we only
> -# install libintl to the target.
> -ifeq ($(BR2_PACKAGE_GETTEXT_TOOLS),)
>  # When static libs are preferred the .so files aren't created
>  ifeq ($(BR2_PREFER_STATIC_LIB),)
>  define GETTEXT_INSTALL_TARGET_CMDS
>  	cp -dpf $(STAGING_DIR)/usr/lib/libintl*.so* $(TARGET_DIR)/usr/lib/
>  endef
>  endif
> -endif # GETTEXT_TOOLS = n
>  
>  # Disable interactive confirmation in host gettextize for package fixups
>  define HOST_GETTEXT_GETTEXTIZE_CONFIRMATION
> -- 
> 1.9.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'