[Buildroot] [git commit] hdparm: prevent package makefile from stripping the hdparm binary

Peter Korsgaard peter at korsgaard.com
Mon Jun 16 07:24:22 UTC 2014


>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:

 > On 06/11/14 23:03, Peter Korsgaard wrote:

 >> +++ b/package/hdparm/hdparm.mk
 >> @@ -12,7 +12,8 @@ HDPARM_LICENSE_FILES = LICENSE.TXT
 >> define HDPARM_BUILD_CMDS
 >> $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
 >> CFLAGS="$(TARGET_CFLAGS)" \
 >> -		LDFLAGS="$(TARGET_LDFLAGS)"
 >> +		LDFLAGS="$(TARGET_LDFLAGS)" \
 >> +		STRIP=/bin/true

 >  Perhaps for consistency we should rename $(TARGET_CROSS)strip to
 > $(TARGET_CROSS)real-strip and symlink $(TARGET_CROSS)strip to /bin/true?

Most of these packages presumably default to 'strip' and not
'$(TARGET_CROSS)strip', so it won't help much.

 >  While looking at this, I also notice that in some cases we _do_ pass the real
 > strip, e.g. in fltk, qt (but not qt5). I guess that's historical accident?

I would think so. For fltk atleast it dates back from 2008. I'll take a
look at fixing it up, thanks.

-- 
Bye, Peter Korsgaard 



More information about the buildroot mailing list