[Buildroot] [PATCH 3/5] legal-info: add a comment about what packages we save the tarballs of

Luca Ceresoli luca at lucaceresoli.net
Wed Jun 18 21:25:06 UTC 2014


Dear Yann,

Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>
> As the legal-info infra only (rightfully) saves the tarballs of packages
> that:
>    - we want to redistribute,
>    - and are not local,
>    - and are not overriden,
>
> add a comment stating so.
>
> This should clarify the code-block, which although trivial to read,
> was not easy to interpret without thinking thouroughly about it.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Luca Ceresoli <luca at lucaceresoli.net>
> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Cc: Fabio Porcedda <fabio.porcedda at gmail.com>
> ---
>   package/pkg-generic.mk | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index a978e63..d16908a 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -602,6 +602,9 @@ ifneq ($$($(2)_LICENSE_FILES),)
>   $(1)-legal-info: $(1)-extract
>   endif
>
> +# We only save the sources of packages we want to redistribute, that are
> +# non-local, and non-overriden. So only store, in the manifest, the tarball
> +# name of those packages.
>   ifeq ($$($(2)_REDISTRIBUTE),YES)
>   ifneq ($$($(2)_SITE_METHOD),local)
>   ifneq ($$($(2)_SITE_METHOD),override)
>

Reviewed-by: Luca Ceresoli <luca at lucaceresoli.net>

-- 
Luca



More information about the buildroot mailing list