[Buildroot] [PATCH 2/2] graph-depends: remove unnecessary redirect of stderr

Samuel Martin s.martin49 at gmail.com
Mon Jun 23 21:13:42 UTC 2014


Arnout, Yann, all,

On Mon, Jun 23, 2014 at 10:42 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> Arnout, All,
>
> On 2014-06-23 22:11 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
>> It hides any error messages reported by make.
>>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>
> Not sure what the test-case for that one would be, but it looks sane.

A test-case is when checking the graph-depends script using:
----
$ python3 ./support/script/graph-depends -p <foo>
Getting dependencies for ['<foo>']
Error getting dependencies ['<foo>']
----
after a rebase (and with some legacy option selected), sadly fails
with no clue at all in the output to help understanding what is wrong
:-(
I had to fire up pdb ;-)

But that true, who else uses the graph-depends script outside the BR
make wrapper? ;-)

>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

Acked-by: Samuel Martin <s.martin49 at gmail.com>
Tested-by: Samuel Martin <s.martin49 at gmail.com>

Regards,

-- 
Samuel



More information about the buildroot mailing list