[Buildroot] [PATCH v2 1/1] atftp: new package

Peter Korsgaard jacmet at uclibc.org
Tue Jun 24 14:19:43 UTC 2014


>>>>> "Ryan" == Ryan Barnett <ryan.barnett at rockwellcollins.com> writes:

 > Signed-off-by: Ryan Barnett <ryan.barnett at rockwellcollins.com>
 > CC: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

 > ---

 > Changes v1 -> v2:
 >  - Added dependancies to IPv6 and threads (suggested by Thomas P.)
 >  - Added more config options along with else cases for pcr and readline
 >    (suggested by Thomas P.)
 >  - Fixed pure static builds (suggested by Thomas P.)
 >      Patch submitted upstream at https://sourceforge.net/p/atftp/bugs/3/
 > ---
 > diff --git a/package/atftp/Config.in b/package/atftp/Config.in
 > new file mode 100644
 > index 0000000..23acf6f
 > --- /dev/null
 > +++ b/package/atftp/Config.in
 > @@ -0,0 +1,15 @@
 > +config BR2_PACKAGE_ATFTP
 > +	bool "atftp"
 > +	depends on BR2_INET_IPV6
 > +	depends on BR2_TOOLCHAIN_HAS_THREADS
 > +	help
 > +	  atftp is a client/server implementation of the TFTP
 > +	  protocol that implements RFCs 1350, 2090, 2347, 2348,
 > +	  and 2349. The server is multi-threaded and the client
 > +	  presents a friendly interface using libreadline.

This is naturally only true if readline is enabled, so I added a comment
describing that.

 > +
 > +	  http://sourceforge.net/projects/atftp/
 > +
 > +comment "atftp needs a toolchain w/ threads, IPv6"
 > +	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INET_IPV6
 > +

You have an extra trailing line here.

Committed with these minor fixes, thanks.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list