[Buildroot] [PATCH] infra: simplify .la/.pc fixup commands
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sun Jun 29 14:48:49 UTC 2014
Dear Thomas De Schampheleire,
On Sun, 29 Jun 2014 16:47:27 +0200, Thomas De Schampheleire wrote:
> >Is this assumption really correct? If the user decides to move
> >$(HOST_DIR) in some custom location using BR2_HOST_DIR, it also means
> >that $(STAGING_DIR) is moved to this custom location. So you can have a
> >case where:
> >
> > BASE_DIR = /home/joe/buildroot/output
> > HOST_DIR = /opt/arm-build
> > STAGING_DIR = /opt/arm-build/usr/arm-unknown-linux-uclibcgnueabi/sysroot/
> >
> >No ?
>
> Hmm, ok, but I'm this case the already applied patch is not complete either and we should go back to v2 I think... I'll resubmit...
>
> ...and I blame Arnout ;-)
Well, I don't know, I haven't tested nor mentally executed your sed
expressions with the use case above in mind, so I don't know if the
patch is actually broken or not. But if you assume that STAGING_DIR is
a subdir of BASE_DIR, I believe it's not a valid assumption, as
explained above.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list