[Buildroot] rsync forces configure step

Fabio Porcedda fabio.porcedda at gmail.com
Mon Jun 30 08:55:42 UTC 2014


On Mon, Jun 30, 2014 at 10:04 AM, Fabio Porcedda
<fabio.porcedda at gmail.com> wrote:
> On Mon, Jun 30, 2014 at 10:02 AM, Cédric Marie
> <cedric.marie at openmailbox.org> wrote:
>> Le 2014-06-13 14:15, Fabio Porcedda a écrit :
>>>
>>> On Fri, Jun 13, 2014 at 2:09 PM, Thomas Petazzoni
>>> <thomas.petazzoni at free-electrons.com> wrote:
>>>>
>>>> This indeed seems correct. I've Cc'ed Fabio who is working on the
>>>> top-level parallel build feature, I guess he'll have a look and give
>>>> you more feedback and/or send a patch fixing this issue.
>>>>
>>>> Thanks a lot for the report!
>>>
>>>
>>> Hi all,
>>> thanks for reporting the issue, I will check it and send a patch to fix
>>> it.
>>
>>
>>
>> Hi Fabio,
>>
>> Have you had the time to have a look at this?
>> I'm currently using the patch I have proposed (with the pipe), but I would
>> be more confident if it was confirmed by an official fix.
>
> Hi Cédric,
> I'm going to check it now.
>
> BR
> --
> Fabio Porcedda

The problem is that the stamp file for rsync is being removed with the
"<pkg>-rebuild" command, so i think that the right fix is:

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 54193d2..67821ec 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -569,9 +569,6 @@ $(1)-graph-depends: graph-depends-requirements
 $(1)-dirclean:         $$($(2)_TARGET_DIRCLEAN)

 $(1)-clean-for-rebuild:
-ifneq ($$($(2)_OVERRIDE_SRCDIR),)
-                       rm -f $$($(2)_TARGET_RSYNC)
-endif
                        rm -f $$($(2)_TARGET_BUILD)
                        rm -f $$($(2)_TARGET_INSTALL_STAGING)
                        rm -f $$($(2)_TARGET_INSTALL_TARGET)

The problem is not related to top-level parallel build, the problem
was present even the previous release (2014.02), the problem was
always existed sine the introduction of the "<pk>-rebuild" feature:

http://git.buildroot.net/buildroot/commit/?id=4ed4e5016b741341059ed826416dad3291df0b2c
Author: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Date:   Thu Sep 29 21:57:39 2011 +0200
   package: add <pkg>-rebuild and <pkg>-reconfigure

Thomas do you know why you removed the sync stamp file?

BR
-- 
Fabio Porcedda



More information about the buildroot mailing list