[Buildroot] [RFC, PATCH 2/8] package/dropbear: Add separate configuration options for client and server
Yann E. MORIN
yann.morin.1998 at free.fr
Mon Mar 3 23:46:54 UTC 2014
Jérémy, All,
On 2014-01-16 16:52 +0800, Jeremy Kerr spake thusly:
[--SNIP--]
> index 68c3b71a..4a7327b7 100644
> --- a/package/dropbear/Config.in
> +++ b/package/dropbear/Config.in
> @@ -8,6 +8,18 @@ config BR2_PACKAGE_DROPBEAR
>
> if BR2_PACKAGE_DROPBEAR
>
> +config BR2_PACKAGE_DROPBEAR_SERVER
> + bool "dropbear ssh server"
> + default y
> + help
> + Enable the dropbear ssh server, run from init
> +
> +config BR2_PACKAGE_DROPBEAR_CLIENT
> + bool "dropbear ssh client"
> + default y
> + help
> + Enable the dropbear ssh client, scp and utilities
What if none is selected? What about:
config BR2_PACKAGE_DROPBEAR_HAS_CLIENT
def_bool y
depends on !BR2_PACKAGE_DROPBEAR_CLIENT
select BR2_PACKAGE_DROPBEAR_SERVER
config BR2_PACKAGE_DROPBEAR_SERVER
bool "dropbear ssh server"
config BR2_PACKAGE_DROPBEAR_CLIENT
bool "dropbear ssh client"
(with your help entries, of course).
> diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
> index 3ef6c8da..a1cc5691 100644
> --- a/package/dropbear/dropbear.mk
> +++ b/package/dropbear/dropbear.mk
> @@ -7,7 +7,7 @@
> DROPBEAR_VERSION = 2013.62
> DROPBEAR_SITE = http://matt.ucc.asn.au/dropbear/releases
> DROPBEAR_SOURCE = dropbear-$(DROPBEAR_VERSION).tar.bz2
> -DROPBEAR_TARGET_BINS = dbclient dropbearkey dropbearconvert scp ssh
> +DROPBEAR_TARGET_BINS = dropbearkey dropbearconvert
> DROPBEAR_MAKE = $(MAKE) MULTI=1 SCPPROGRESS=1 \
> PROGRAMS="dropbear dbclient dropbearkey dropbearconvert scp"
^^^^^^^^
Should we not disable dbclient if it is not selected?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list