[Buildroot] [PATCH] syslinux: install helper programs to the host

[Frank Hunleth]

On Mon, Mar 17, 2014 at 2:47 AM, Arnout Vandecappelle <arnout at mind.be> wrote:
>
> On 03/16/14 20:04, Frank Hunleth wrote:
> > Even though syslinux is built for the target, it does create helper
> > programs intended to be run on the host such as syslinux and extlinux.
> > This change installs these helper programs to the host so that they may be
> > called by post image creation scripts.
>
>  So what is host-syslinux for then?

This was confusing to me. host-syslinux isn't used anywhere and can't
be enabled, so it looks like it can be deleted. Additionally, the
Config.in has options for the target syslinux which makes you believe
that it's the way to go if you want syslinux.

>  In fact, we currently have two ways for installing the host-tools of
> bootloaders:
>
> 1. An explicit host-foo package, used by syslinux and u-boot. In the case
> of u-boot, it's even a separate package u-boot-tools in package/
>
> 2. Implicit when installing to target, used by grub, and grub2 (and by
> this patch as well). In the case of grub2, nothing is installed to target
> in fact, instead it's installed to HOST_DIR.
>
>  So maybe we should converge on a single mechanism for all
> bootloader-host-tools. I'm personally in favour of option 1, but I have
> no strong opinion.

This is my first x86/buildroot project, so I'm fine with whatever the
consensus decides.

Thanks,
Frank

>
>  Regards,
>  Arnout
>
>
> >
> > Signed-off-by: Frank Hunleth <fhunleth at troodon-software.com>
> > ---
> >  boot/syslinux/syslinux.mk | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/boot/syslinux/syslinux.mk b/boot/syslinux/syslinux.mk
> > index eedc364..7b3f9cf 100644
> > --- a/boot/syslinux/syslinux.mk
> > +++ b/boot/syslinux/syslinux.mk
> > @@ -11,7 +11,6 @@ SYSLINUX_SITE    = $(BR2_KERNEL_MIRROR)/linux/utils/boot/syslinux/4.xx/
> >  SYSLINUX_LICENSE = GPLv2+
> >  SYSLINUX_LICENSE_FILES = COPYING
> >
> > -SYSLINUX_INSTALL_TARGET = NO
> >  SYSLINUX_INSTALL_IMAGES = YES
> >
> >  SYSLINUX_DEPENDENCIES = host-nasm host-util-linux
> > @@ -23,6 +22,12 @@ define SYSLINUX_BUILD_CMDS
> >       $(TARGET_MAKE_ENV) $(MAKE) CC="$(HOSTCC) -idirafter $(HOST_DIR)/usr/include $(HOST_LDFLAGS)" AR="$(HOSTAR)" -C $(@D)
> >  endef
> >
> > +define SYSLINUX_INSTALL_TARGET_CMDS
> > +     # While the actual bootloader is compiled for the target, several
> > +     # utilities for installing the bootloader are meant for the host.
> > +     $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) INSTALLROOT=$(HOST_DIR) install
> > +endef
> > +
> >  SYSLINUX_IMAGES-$(BR2_TARGET_SYSLINUX_ISOLINUX) += isolinux.bin
> >  SYSLINUX_IMAGES-$(BR2_TARGET_SYSLINUX_PXELINUX) += pxelinux.bin
> >
> >
>
>
> --
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F




-- 
Frank Hunleth
Troodon Software LLC
Embedded Software Development
http://troodon-software.com/