[Buildroot] [PATCH] eigen: (optionally) install unsupported modules

Samuel Martin s.martin49 at gmail.com
Wed Mar 19 07:25:55 UTC 2014


Thomas, Davide, all,

On Tue, Mar 18, 2014 at 11:55 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Davide Viti,
>
> On Tue, 18 Mar 2014 21:18:14 +0100, Davide Viti wrote:
>> From: Davide Viti <d.viti at infosolution.it>
[...]
>>
>> +define EIGEN_INSTALL_UNSUPPORTED_MODULES
>> +     cp -a $(@D)/unsupported $(STAGING_DIR)/usr/include/
>
> I'm a bit worried about having a directory called
> $(STAGING_DIR)/usr/include/unsupported. Shouldn't this directory be
> installed *below* the $(STAGING_DIR)/usr/include/Eigen directory
> created by the normal installation of Eigen?

This goes a bit against what eigen's build-system (cmake) does by default.
The "Eigen" and "unsupported" directories are installed in the same
include directory
(defaults: /usr/include/eigen3).

I agree such a change may break some code in Buildroot users' code,
but I'm also worried about not following default install scheme done
by upstream projects.


Regards,

-- 
Samuel



More information about the buildroot mailing list