[Buildroot] [PATCH 1/1] dbus-triggerd: new package

[Arnout Vandecappelle]

On 26/03/14 08:01, Arnaud Rébillout wrote:
> Hi Arnout,
> 
>>  For the other dbus-* packages, the dbus dependencies are repeated (even
>> though they're automatic because of the depends on DBUS). So I would do
>> that here as well. And that means of course that there should also be a
>> comment in case of missing toolchain features. See dbus-cpp for an example.
> You're right, I forgot the comments, and the host-pkgconf dependency as well.
> I will do as you suggest for the DBUS dependencies.
> 
>>  Patch misses a description + Signed-off-by.
> Correct.
> 
>>  If you're anyway patching the Makefile, you can just as well make it:
>>
>> CFLAGS?=-Wall -O3
>> CFLAGS+=`$(PKG_CONFIG) --cflags dbus-1`
>> LDLIBS+=`$(PKG_CONFIG) --libs dbus-1`
>>
>>
>>
>>  Will you send this patch upstream?
> Yep. I will send a patch right now.
> 
> 
>>  This should be $(TARGET_CONFIGURE_OPTS) which includes all of the above
>> and more.
> OK. Actually, I've always been wondering it was OK to use
> TARGET_CONFIGURE_OPTS in a generic package, I never dared to do it.

 Yeah, it should be renamed, really.

 Regards,
 Arnout

> 
>>  Note BTW that the patch above refers to LDLIBS instead of LDFLAGS. Is
>> LDFLAGS used?
> Yep, LDFLAGS is used automatically by Make in this Makefile.
> 
> 
> 
> Thanks for your comments, I will send the patch upstream a wait a little
> for the author's comments on it.
> 
> 
> Regards
> 
> 
> -- 
> Arnaud Rébillout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F