[Buildroot] [PATCH 0/9] Documentation cleanup

Jerzy Grzegorek jerzy.grzegorek at trzebnica.net
Sat Mar 29 10:59:26 UTC 2014


Hi Thomas,

> Dear Jerzy Grzegorek,
>
> On Sat, 29 Mar 2014 10:52:38 +0100, Jerzy Grzegorek wrote:
>
>> Regarding the "may be added", I agree.
>> I proposed this change because I saw on mailing list both cases of
>> submitting patch series introduced by a cover letter:
>>
>>    * "in addition" case:
>>       [Patch vX 0/Y] ...
>>       [Patch vX 1/Y] ...
>>       ...
>>       [Patch vX Y/Y] ...
>>
>> * "instead" case:
>>       [Patch vX 0/Y] ...
>>       [Patch 1/Y] ...
>>       ...
>>       [Patch Y/Y] ...
> To me, this second variant is wrong. This is because the cover letters
> are not recorded by patchwork, so if the version is not mentioned in
> the title of each individual patch, patchwork will not have the
> information of the version of the patches.
>
>> So maybe it should be:
>> "Note that when your patch series is introduced by a cover letter,
>> a patch version should be added to the cover letter in addition to
>> the individual commits."
> But is it really necessary? Such a wording seems to imply that the
> contributor would have to do this manually, while the contributor
> should instead simply use "git format-patch --subject-prefix", which
> does just the right thing.

Ok, agree.
You haven't changed
C++  -->  C\++
for my patch 2.

Regards,
Jerzy

>
> Thomas




More information about the buildroot mailing list