[Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

Thomas De Schampheleire patrickdepinguin at gmail.com
Thu May 1 19:16:42 UTC 2014


Hi,

On Mon, Feb 17, 2014 at 11:36 AM, Thomas De Schampheleire
<patrickdepinguin at gmail.com> wrote:
> Hi,
>
> On Mon, Feb 17, 2014 at 11:32 AM, Thomas Petazzoni
> <thomas.petazzoni at free-electrons.com> wrote:
>> Dear Noam Camus,
>>
>> On Mon, 17 Feb 2014 08:10:17 +0000, Noam Camus wrote:
>>
>>> Is there anything I can do to help in applying those commits?
>>>
>>> Noam
>>> Note: at the moment only one out of five was applied.
>>
>> Yes, I believe you could resend them, rebased on top of the current
>> -next branch, in a patch series that only includes those patches (the
>> fact that you sent only 5 patches, but they were number <something>/29
>> was quite confusing).
>>
>> Also, make sure each of your commits has a long enough commit log to
>> allow reviewers to understand what problem the commit is fixing, and
>> how the solution works.
>
> This specific patch 02/29 (uClibc .config) is at least partially
> addressed in the meantime, with commit
> http://git.buildroot.org/buildroot/commit/?id=a25df76b39863e5d1a4e927696bf83055e8ce244

The second part of this patch should also be fixed now: we no longer
use --cvs-exclude in the rsync step, but have an explicit list of
version-controlled directories to exclude from the rsync. The pattern
*.old is not in the exclusion list, so is copied from the overriden
dir.

I'm therefore marking this patch as Superseded in patchwork.
Do let me know if you think my analysis is not correct.

Best regards,
Thomas


More information about the buildroot mailing list