[Buildroot] [PATCH v3 1/2] ccache: change default cache directory path to match config setting

Thomas De Schampheleire patrickdepinguin at gmail.com
Thu May 1 14:01:10 UTC 2014


Danomi Manchego <danomimanchego123 at gmail.com> schreef:
>Thomas,
>
>On Thu, May 1, 2014 at 1:52 AM, Thomas De Schampheleire
><patrickdepinguin at gmail.com> wrote:
>> You  should have pasted my review and test tags here...
>>
>> Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
>> Tested-by : Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
>
>Such tags survive the rev process?  In this case, this patch didn't
>change from v2 to v3, but in general, I thought it might be
>disingenuous to claim those fields on rev X, when they were granted on
>rev X-n ...

They only survive on unchanged revisions, which was the case on this first patch. Indeed for changed revisions, like the second patch, any tag should not be copy pasted as the content is different.

Best regards,
Thomas





More information about the buildroot mailing list