[Buildroot] [PATCH] graphs: add option to remove transitive dependencies in dependency graph

[Samuel Martin]

Yann, all,

On Fri, May 9, 2014 at 3:34 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> Samuel, All,
>
> On 2014-05-09 13:16 +0200, Samuel Martin spake thusly:
>> > On 2014-05-09 12:00 +0200, Peter Korsgaard spake thusly:
> [--SNIP--]
>> >> Thanks. Like I mentioned on IRC I do like the looks of the graphs, but
>> >> I'm not really happy with the use of environment variables to control
>> >> it, as it isn't intuitive.
>>
>> I'm not a big fan of env. vars. either.
> [--SNIP--]
>> An alternaitve solution could be using a config file; Python has some
>> packages for this [1] ;-).
>> This way, the config file could be initialized with what is set in the
>> menuconfig, so used as defaults.
>> If some options are passed on the command line, they will override
>> these defaults.
>> If someone wants to do something more fancy and automatic, then one
>> just could update the config file.
>
> Well, this does not solve the issue at hand: how do we pass options on
> the command line in the first place?
>
> We added 'graph-depends' and 'PKG-graph-depends' (and 'graph-build'
> too) as make targets so it was easier for users to generate the graphs
> rather than directly call the scripts (since the scripts could even
> reside in another dir when building out-of-tree, and it would be more
> complex to reach for the scripts).

Arf! I forgot this.

In this case, I would do:
- to get the default graph:
  make foo-graph-depends
- to get a customized graph:
  make foo-graph-depends BR2_GRAPH_DEPS_OPTS="..."

And I'd expect to find some help somewhere in the doc to know what are
the supported options, or how to get the graph-depends help, so via
the manual or in the help message of the BR2_GRAPH_DEPS_OPTS kconfig
entry.

So, in the end, the call to graph-depends script would just be:
  $(TOPDIR)/support/scripts/graph-depends $(BR2_GRAPH_DEPS_OPTS)
or:
  $(TOPDIR)/support/scripts/graph-depends -p $(1) $(BR2_GRAPH_DEPS_OPTS)

No black magics with the args... just keep it simple ;-)
"Buildroot is a simple, efficient and easy-to-use tool" (not from me,
from http://buildroot.org/ :-])

my 2 cents

>
> Adding a config file would not help much either: modifying the config
> file can't easily be automated, which is all the point in being able to
> pass extra args when generating the graphs.

right.

Regards,


-- 
Samuel