[Buildroot] [PATCH v3] toolchain-external: Fix EABIhf check

[Arnout Vandecappelle]

On 09/05/14 09:23, Thomas De Schampheleire wrote:
> Hi Arnout,
> 
> On Fri, May 9, 2014 at 12:35 AM, Arnout Vandecappelle <arnout at mind.be> wrote:
>> On 06/05/14 13:25, Thomas De Schampheleire wrote:
[snip]
>>
>>> +             abistr_$(BR2_ARM_EABI)='EABI'; \
>>> +             abistr_$(BR2_ARM_EABIHF)='EABIhf'; \
>>> +             echo "Incorrect ABI setting: $${abistr_y} selected, but toolchain is incompatible"; \
>>
>>  Nice approach! But to keep the original output, you could use:
>>
>> $${abistr_y} selected, but toolchain uses $${abistr_}
>>
> 
> This did cross my mind, but it assumes that there are only two
> possibilities: EABI and EABIhf. Suppose that a new EABI pops up. Or
> suppose the compilation/link step fails for a completely different
> reason. Then we have told the user that their toolchain is EABI or
> EABIhf while it is not true.
> So here I choice correctness over completeness, but if you prefer I
> can change it. Do let me know if you still think we should add
> $${abistr_} to the message.

 Good point, let's say "incompatible" then.

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F