[Buildroot] [PATCH] dropbear: fix missing directory with systemd

[Maxime Hadjinlian]

Hi Peter, all,

On Tue, May 27, 2014 at 11:12 AM, Peter Korsgaard <jacmet at uclibc.org> wrote:
>>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian at gmail.com> writes:
>
>  > With the current systemd unit files, the folder '/etc/dropbear' is not
>  > created, which caused dropbear to fail to create its keys and then
>  > accept connections.
>
>  > This add a new file which is used by systemd to create the correct
>  > directory structure.
>
>  > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
>  > ---
>  >  package/dropbear/dropbear.mk            | 3 +++
>  >  package/dropbear/dropbear_tmpfiles.conf | 1 +
>  >  2 files changed, 4 insertions(+)
>  >  create mode 100644 package/dropbear/dropbear_tmpfiles.conf
>
>  > diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
>  > index 2ac6211..f176f7c 100644
>  > --- a/package/dropbear/dropbear.mk
>  > +++ b/package/dropbear/dropbear.mk
>  > @@ -49,6 +49,9 @@ define DROPBEAR_INSTALL_INIT_SYSTEMD
>  >      mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
>  >      ln -fs ../dropbear.service \
>  >              $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/dropbear.service
>  > +    mkdir -p $(TARGET_DIR)/usr/lib/tmpfiles.d
>  > +    $(INSTALL) -D -m 644 package/dropbear/dropbear_tmpfiles.conf \
>  > +            $(TARGET_DIR)/usr/lib/tmpfiles.d/dropbear.conf
>
> Why the tmpfiles dance and not just a mkdir -p
> $(TARGET_DIR)/etc/dropbear? It is not really specific to systemd, so we
> could just do it in _INSTALL_TARGET_CMDS (and remove the mkdir in
> S50dropbear).
Yes you're right after all it's needed for the right execution of the
program, it's not temporary at all.
I'll do another patch today.

Thanks
>
> --
> Bye, Peter Korsgaard