[Buildroot] [PATCH] Improve tar check if bsdtar is installed

Thomas De Schampheleire patrickdepinguin at gmail.com
Fri May 30 18:24:42 UTC 2014


Heiko Abraham <abrahamh at web.de> schreef:
>If bsdtar is installed, fix script error for tar version detection.
>Set tar version to 'invalid' to trigger rebuild of 'host-tar'.
>---
> support/dependencies/check-host-tar.sh | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/support/dependencies/check-host-tar.sh b/support/dependencies/check-host-tar.sh
>index 2cfc2b3..b5818f0 100755
>--- a/support/dependencies/check-host-tar.sh
>+++ b/support/dependencies/check-host-tar.sh
>@@ -14,10 +14,18 @@ fi
> # Output of 'tar --version' examples:
> # tar (GNU tar) 1.15.1
> # tar (GNU tar) 1.25
>+# bsdtar 2.8.3 - libarchive 2.8.3
> version=`$tar --version | head -n 1 | sed 's/^.*\s\([0-9]\+\.\S\+\).*$/\1/'`
> major=`echo "$version" | cut -d. -f1`
> minor=`echo "$version" | cut -d. -f2`
> bugfix=`echo "$version" | cut -d. -f3`
>+version_bsd=`$tar --version | grep 'bsdtar'`
>+if [ ! -z "${version_bsd}" ] ; then 
>+  # mark as invalid tar version
>+  major=1
>+  minor=14
>+  bugfix=1
>+fi

Could you clarify what the problem is with bsdtar and add this as a comment in the patch?

Also, the magic 1.14.1 is pretty odd, you could just as well take 0.0.0

Best regards,
Thomas




More information about the buildroot mailing list