[Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3

[Jörg Krause]

Yann, Peter, All,

On Sa, 2014-11-01 at 20:13 +0100, Yann E. MORIN wrote:
> Jörg, All,
> 
> On 2014-11-01 00:46 +0100, Jörg Krause spake thusly:
> > On Fr, 2014-10-31 at 12:50 +0100, Peter Korsgaard wrote:
> > > commit: http://git.buildroot.net/buildroot/commit/?id=e6c04e6daae674f8983ec2fb106fb897c6803c32
> > > branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> > > 
> > > Fixes:
> > > http://autobuild.buildroot.net/results/daa/daad247db16818f25ab33402e26e27257defbe13/
> > > http://autobuild.buildroot.net/results/720/720e2c8a5eab8b47d2510fe03b4a90ec8beafc17/
> > > http://autobuild.buildroot.net/results/02b/02b4ab9ee07707ee4a4d4ea2b9c67bee91b1392d/
> > > http://autobuild.buildroot.net/results/819/81914317ce82dc1321484d8c2b65647f92aa6929/
> > > 
> > > And many others.
> [--SNIP--]
> > This patch breaks building avahi for me. Is autoreconf really intended?
> > Removing it fixed my build.
> > 
> >         >>> avahi 0.6.31 Autoreconfiguring
> [--SNIP--]
> >         configure.ac:419: error: possibly undefined macro:
> >         AM_GLIB_GNU_GETTEXT
> >               If this token and others are legitimate, please use
> >         m4_pattern_allow.
> 
> It seems it requires gettext.
> 
> Jörg, care to test adding this to avahi.mk (just below AUTORECONF):
> 
>     AVAHI_GETTEXTIZE = YES

this doesn't help. The problem is the AM_GLIB_GNU_GETTEXT macro at
configure.ac:419. If I enable glibc avahi builds without errors. I've
also found some old posts about this issue, e.g:
http://blogs.gnome.org/jjardon/2010/10/08/use-upstream-gettext-instead-the-glib-one/

I followed this suggestions and replaced AM_GLIB_GNU_GETTEXT with:
        AM_GNU_GETTEXT_VERSION([0.19.3])
        AM_GNU_GETTEXT([external])
and it works for me.

I am not sure about the version number I should use for gettext. The
most recent one?

I am not an expert about autotools. So what do you think about this? May
I submit a patch for this issue?

Many thanks
Jörg