[Buildroot] [PATCH] Update github helper URL.

Arnout Vandecappelle arnout at mind.be
Thu Nov 13 20:05:56 UTC 2014


On 13/11/14 20:58, Arnout Vandecappelle wrote:
> On 13/11/14 20:48, Patrick Williams wrote:
>> Github changed the URL syntax from 'archive' back to 'tarball'.
>>
>> Signed-off-by: Patrick Williams <iawillia at us.ibm.com>
>> ---
>>  package/pkg-download.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
>> index 4cfb913..03907f1 100644
>> --- a/package/pkg-download.mk
>> +++ b/package/pkg-download.mk
>> @@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c
>>  domainseparator=$(if $(1),$(1),/)
>>  
>>  # github(user,package,version): returns site of GitHub repository
>> -github = https://github.com/$(1)/$(2)/archive/$(3)
>> +github = https://github.com/$(1)/$(2)/tarball/$(3)
>>  
>>  ################################################################################
>>  # The DOWNLOAD_* helpers are in charge of getting a working copy
>>
> 
>  Yep, that seems to work! So Yann, stop working :-)
> 
>  I haven't tested if it's exactly the same tarball. It redirects to a URL
> containing legacy.tar.gz instead of tar.gz, so who knows...

 Checked with a few tarballs, and it seems they only differ in the basename:

legacy (i.e., this patch):
	zeromq-cppzmq-1f05e0d/
current (i.e., archive/version.tar.gz):
	cppzmq-1f05e0d111197c64be32ad5aecd59f4d1b05a819/

 So the legacy really looks better :-)

 Therefore:

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F



More information about the buildroot mailing list