[Buildroot] [PATCH v3 5/5] package: linux-fusion: use install instead of cp

[Arnout Vandecappelle]

On 17/11/14 18:19, Guido Martínez wrote:
> in order to not depend on the previous permissions of the file
> 
> Signed-off-by: Guido Martínez <guido at vanguardiasur.com.ar>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

 There are a few more suspicious cp instances:

board/boundarydevices/nitrogen6x/post-build.sh
boot/grub/grub.mk
fs/iso9660/iso9660.mk


 Also, it would be good to document somewhere (e.g. in the intro mail) why the
rsync in the toolchain is OK. Or even better, replace it even though it's not
really necessary - it just feels more consistent and safe.


 Regards,
 Arnout

> ---
>  package/linux-fusion/linux-fusion.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/linux-fusion/linux-fusion.mk b/package/linux-fusion/linux-fusion.mk
> index c5e7976..001388c 100644
> --- a/package/linux-fusion/linux-fusion.mk
> +++ b/package/linux-fusion/linux-fusion.mk
> @@ -36,8 +36,8 @@ define LINUX_FUSION_INSTALL_TARGET_CMDS
>  		$(LINUX_FUSION_MAKE_OPTS) \
>  		INSTALL_MOD_PATH=$(TARGET_DIR) \
>  		-C $(@D) install
> -	mkdir -p $(LINUX_FUSION_ETC_DIR)
> -	cp -dpf package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)
> +	$(INSTALL) -D -m 644 package/linux-fusion/40-fusion.rules \
> +		$(LINUX_FUSION_ETC_DIR)/40-fusion.rules
>  endef
>  
>  $(eval $(generic-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F