[Buildroot] [PATCH 2/3] live555: add support for building dynamic libraries

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Nov 19 09:03:38 UTC 2014


Dear Baruch Siach,

On Wed, 19 Nov 2014 07:54:02 +0200, Baruch Siach wrote:

> > I don't understand why you need a separate config.linux and
> > config.linux-with-shared-libraries. Since in Buildroot we will either
> > be building with BR2_PREFER_STATIC_LIB=y, or BR2_PREFER_STATIC_LIB
> > disabled, why not simply call the file config.linux, as it was called
> > before this patch?
> > 
> > Of course, the LIVE555_LIBRARY_LINK think is needed, but I don't see
> > why the other changes are needed.
> > 
> > Can you expand on this?
> 
> Both config.linux and config.linux-with-shared-libraries already exist in 
> upstream code. We are only appending to these files to override some 
> variables. The linux-with-shared-libraries variant defines a few additional 
> variables needed for dynamic linking (library version, installation target). 
> Aligning to upstream build procedure should be more future proof, IMO.

Thanks for the explanation, definitely makes sense. I've added part of
this paragraph of explanation to the commit log, and then applied both
this patch, as well as the patch that allows VLC to link dynamically
against live555 to the next branch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list