[Buildroot] [PATCH next 2/3] package/tvheadend: Add support for liburiparser

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sun, 23 Nov 2014 20:56:52 +0100, Bernd Kuhls wrote:

> +ifeq ($(BR2_PACKAGE_LIBURIPARSER),y)
> +TVHEADEND_DEPENDENCIES += liburiparser
> +TVHEADEND_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) $(if $(BR2_USE_WCHAR),,-DURI_NO_UNICODE)"

This is a little bit dangerous, because if another part of tvheadend.mk
wants to add some stuff to the CFLAGS, it will no longer be possible.
It would have been a bit better to do:

TVHEADEND_CFLAGS = $(TARGET_CFLAGS)
ifeq ($(BR2_PACKAGE_LIBURIPARSER),y)
TVHEADEND_CFLAGS += $(if $(BR2_USE_WCHAR),,-DURI_NO_UNICODE)
endif

and then:

>  TVHEADEND_DEPENDENCIES += dtv-scan-tables
>  
>  define TVHEADEND_CONFIGURE_CMDS
>  	(cd $(@D);				\
>  	 $(TARGET_CONFIGURE_OPTS)		\
>  	 $(TARGET_CONFIGURE_ARGS)		\
> +	 $(TVHEADEND_CONF_ENV)			\

	 CFLAGS="$(TVHEADEND_CFLAGS)"

I have nonetheless committed your proposal to next, it will always be
time to improve things later when a second condition needs to adjust
the CFLAGS.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com