[Buildroot] [PATCH v4 next 1/5] support/download: silence git if it is a silent build

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Nov 26 21:55:21 UTC 2014


Dear Yann E. MORIN,

On Wed, 26 Nov 2014 22:44:42 +0100, Yann E. MORIN wrote:

> Well, the fact that we relied on the fact that -q is optional so had to
> be the fifth argument is what bothered me. If we were to be adding new
> optional flags, we'd be stuck. Passing them through the environment made
> it possible to add extra optional flags (although I wonder what those
> might be).

Yes, agreed: what bothered me is to start having optional arguments,
but use only the position of arguments. This clearly makes it difficult
to have additional optional arguments

> No need to recognise long options, though; shirt options are enough.

Agreed, short options are good enough.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list