[Buildroot] [PATCH 05 of 15] packages: rename FOO_INSTALL_HOST_OPT into FOO_INSTALL_HOST_OPTS
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sat Oct 4 16:52:59 UTC 2014
Dear Yann E. MORIN,
On Sun, 28 Sep 2014 00:15:06 +0200, Yann E. MORIN wrote:
> > diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
> > --- a/package/pkg-cmake.mk
> > +++ b/package/pkg-cmake.mk
> > @@ -41,7 +41,7 @@
> > $(2)_MAKE ?= $$(MAKE)
> > $(2)_MAKE_ENV ?=
> > $(2)_MAKE_OPTS ?=
> > -$(2)_INSTALL_HOST_OPT ?= install
> > +$(2)_INSTALL_HOST_OPTS ?= install
>
> The other infras do not use a 'HOST_' in the middle of host-variant
> variables; 'HOST_' is only present at the beginning.
>
> For example, we have HOST_LIBFOO_INSTALL_CMDS that contrasts to
> LIBFOO_INSTALL_{TARGET,STAGING,IMAGES}_CMDS.
>
> So, I find there is a bit of discrepancy in this variable naming. Plus,
> it is not documented in the manual.
>
> Samuel, is there a reason for the naming of this variable?
I fully agree with Yann comments here. Samuel, could you answer Yann's
question?
Is anyone willing to cook a patch to fix this?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list