[Buildroot] [PATCH] bandwidthd: fix static build

[Baruch Siach]

Hi Nathaniel,

On Fri, Oct 03, 2014 at 02:35:19PM +0800, Nathaniel Roach wrote:
> On 02/10/14 16:33, Baruch Siach wrote:
> > On Thu, Oct 02, 2014 at 04:24:41PM +0800, Nathaniel Roach wrote:
> >> On 02/10/14 15:58, Baruch Siach wrote:
> >>> On Thu, Oct 02, 2014 at 03:56:08PM +0800, Nathaniel Roach wrote:
> >>>> I do vaguely remember some issue with -lpthread, could you send me the
> >>>> config?
> >>>>
> >>>> (It was a while ago, but I'm sure I tested the patch with a basic ARM
> >>>> config, and IIRC I had the -lpthread issue once or twice but was never
> >>>> able to reproduce it after my patch)
> >>>
> >>> Get the config from 
> >>> http://autobuild.buildroot.net/results/e49/e496cc4315c06de61379222d3e842d4cd05b2f71/config.
> >>
> >> After testing that, you are indeed correct.
> >>
> >> I've gone through the emails from a while ago and it's something like this:
> >>
> >> Bandwidthd needs libpcap.
> >> If libpcap was compiled with libusb that needs to be checked for/handled.
> >> And if libusb was used apparently /that/ is what needs pthreads, thus
> >> adding an additional dependency on the configure.ac.
> >>
> >> I'm not sure why I added a hard pass/fail check for lpthread, as I would
> >> have thought I've done it like I handled like the lpng/zlib issue...
> >>
> >> I'll have a play around and see what I can do.
> > 
> > The libpcap package provides the helpful pcap-config utility that is more or 
> > less equivalent to pkg-config. grep pcap-config in buildroot to see how it is 
> > being used to fix static build problems.
> 
> Hi Baruch, I didn't end up using pcap-config, but could you check git
> version 4b07a0b3d3a280cdde582060cb29f3333ba4bf6e for me? It seems to
> work in the config you pasted above and I haven't had any issues in my
> other tests.

I can confirm that upgrading bandwidthd to 
4b07a0b3d3a280cdde582060cb29f3333ba4bf6e fixes the build of the config above. 
I still think that holding the complete knowledge of all your indirect 
dependencies, mandatory and optional, is not robust. A better future proof 
solution IMO is to use tools like pkg-config (or pcap-config in the case of 
libpcap) to list all dependencies that are in actual use for this specific 
build. But this is your call as upstream.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -