[Buildroot] [PATCH 1/2] automake: update gtk-doc.m4 to serial 2
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Oct 10 13:28:56 UTC 2014
Dear Gustavo Zacarias,
On Fri, 10 Oct 2014 08:12:15 -0300, Gustavo Zacarias wrote:
> > Yes, correct, that's my idea. I think it's more correct than globally
> > adding this host-pkgconf dependency.
>
> "When you autoreconf you might need host-pkgconf in DEPENDENCIES whereas
> you didn't before"... really?
Come on Gustavo, no need to start being aggressive here.
Yes, that's exactly what I suggest. And actually, we already need to
add host-pkgconf in DEPENDENCIES when doing autoreconf, if the
configure.ac uses PKG_CHECK_MODULES, which is far more common than
packages using gtk-doc.m4 specifically.
PKG_CHECK_MODULES in configure.ac requiring host-pkgconf in the
DEPENDENCIES is precisely the reason why I proposed
http://patchwork.ozlabs.org/patch/340902/ some time ago. Nothing
prevents from adding a similar check to see if the package uses
the gtk-doc.m4 macros or not. That would at least warn loudly if such
macros are used without the package having host-pkgconf in its
dependencies.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list