[Buildroot] [PATCH 1/2] automake: update gtk-doc.m4 to serial 2

[Gustavo Zacarias]

On 10/10/2014 10:28 AM, Thomas Petazzoni wrote:

> Come on Gustavo, no need to start being aggressive here.

Huh? It's not intended to be aggressive.

> Yes, that's exactly what I suggest. And actually, we already need to
> add host-pkgconf in DEPENDENCIES when doing autoreconf, if the
> configure.ac uses PKG_CHECK_MODULES, which is far more common than
> packages using gtk-doc.m4 specifically.
> 
> PKG_CHECK_MODULES in configure.ac requiring host-pkgconf in the
> DEPENDENCIES is precisely the reason why I proposed
> http://patchwork.ozlabs.org/patch/340902/ some time ago. Nothing
> prevents from adding a similar check to see if the package uses
> the gtk-doc.m4 macros or not. That would at least warn loudly if such
> macros are used without the package having host-pkgconf in its
> dependencies.

Well, at least from my POV it's making some packages need host-pkgconf
just because they use gtk-doc.m4, we're bumping the version and they're
AUTORECONFed. If they weren't AUTORECONFed they maybe didn't need
host-pkgconf (maybe for other purposes, but not because of the old
gtk-doc.m4) so it seems to me it's autotools/autoreconfs fault, and it
should be handled there.
It has nothing to do with packages that don't account for host-pkgconf
usage without accounting for it in the first place.
Regards.