[Buildroot] [PATCH] libevent: use github call

Maxime Hadjinlian maxime.hadjinlian at gmail.com
Sun Oct 12 17:22:43 UTC 2014


On Sun, Oct 12, 2014 at 7:08 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Maxime Hadjinlian,
>
> On Sun, 12 Oct 2014 19:06:23 +0200, Maxime Hadjinlian wrote:
>
>> >> My personal point of view is that if there's a tarball, then we should
>> >> use it. Don't know if that opinion is shared by the community as a
>> >> whole, please ask right now during the meeting :-)
>> >
>> > I agree.
>> It seems that the tarball available on the website, is the tarball
>> generated by github from the tag.
>
> Yes, and?
To put everything cleary in a mail:

When a maintainer do a release from github, there's two possibilities:
Either you don't upload a file, then the tarball you download is
generated from the tag.

Or you upload a file, and then the tarball, is *NOT* generated, it's
the file that you uploaded.

Since the hepers, will call the http URL of github (and not doing a
git clone), for me the github helper is used for any generated
tarball.
*BUT* if the releases is a manually uploaded file, then we have to
uses the http link and not the helper. I'd recommend to put a comments
on each one theses cases.

In the case of libevent, the link from the website points to the
release on github, which is a generated tarball, not an uploaded one.
So the uses of the helper is perfectly fine here.

Hope I gave enough details here, maybe this should be put in the
manual ? Don't know if it's really usefull.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com



More information about the buildroot mailing list