[Buildroot] [PATCH] fs/iso9660: add dependencies for make source

Károly Kasza kaszak at gmail.com
Sat Oct 18 14:17:46 UTC 2014


Hi,

>>
> >> +ROOTFS_ISO9660_DEPENDENCIES = host-cdrkit host-fakeroot linux
> rootfs-cpio grub
> >> +
> >>  $(BINARIES_DIR)/rootfs.iso9660: host-cdrkit host-fakeroot linux
> rootfs-cpio grub
>
>  You should use $(ROOTFS_ISO9660_DEPENDENCIES) here.
>
>
Why? Non of the other rootfs target makefiles use that (fs/*/*.mk).


> > How about putting the dependencies variables on the top ?
> > Also, please keep the dependencies alphabetically sorted.
> > I know they are not ordered the line below, but it would be nice.
>
>  Well, now they're ordered according to how they appear in the makefiles,
> i.e.
> first the real packages, then the kernel, then the rootfs, then the
> bootloader.
>
>  Hm, actually, the bootloader should come before the kernel in that
> reasoning...
>
>  So alphabetically is probably better :-)
>

Technically, the dependencies variable is already at the top, before the
first make target.
Also, it's not on the exact top of the file in any other rootfs target
makefiles.
Regarding the order: I don't really think that matters.

Regards,
Karoly
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141018/89f7f1cc/attachment-0002.html>


More information about the buildroot mailing list